Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: use Date instead of a string in times and stops helpers #9933

Merged
merged 1 commit into from
Dec 4, 2024
Merged

front: use Date instead of a string in times and stops helpers #9933

merged 1 commit into from
Dec 4, 2024

Conversation

emersion
Copy link
Member

@emersion emersion commented Dec 3, 2024

Improves type safety.

@emersion emersion requested a review from a team as a code owner December 3, 2024 16:25
@emersion emersion self-assigned this Dec 3, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2024
SharglutDev
SharglutDev approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

anisometropie
anisometropie approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@anisometropie anisometropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, tested and looking good

@emersion emersion added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@emersion emersion added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 8a1981a Dec 4, 2024
27 checks passed
@emersion emersion deleted the emr/times-stops-date branch December 4, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees

@emersion emersion

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @anisometropie @SharglutDev