Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display path steps even if the simulation failed #9962

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Dec 5, 2024

closes #8418

@clarani clarani requested a review from a team as a code owner December 5, 2024 13:19
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 43.78698% with 95 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (7b66739) to head (13fd95a).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...alStudies/hooks/useSetupItineraryForTrainUpdate.ts 3.77% 51 Missing ⚠️
...les/operationalPoint/helpers/buildOpSearchQuery.ts 9.52% 38 Missing ⚠️
...dules/trainschedule/helpers/computeBasePathStep.ts 88.67% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9962      +/-   ##
==========================================
- Coverage   80.11%   80.03%   -0.09%     
==========================================
  Files        1048     1049       +1     
  Lines      105250   105293      +43     
  Branches      756      757       +1     
==========================================
- Hits        84325    84269      -56     
- Misses      20884    20983      +99     
  Partials       41       41              
Flag Coverage Δ
editoast 74.23% <ø> (-0.04%) ⬇️
front 89.23% <43.78%> (-0.13%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Dec 5, 2024

osrdToNge already does the exact same kind of logic. Would be nice to de-duplicate.

@clarani clarani force-pushed the cni/8418-display-pathsteps-even-if-simulation-fails branch 5 times, most recently from 4fd1cf5 to 1c93b1c Compare December 6, 2024 11:13
@clarani clarani enabled auto-merge December 6, 2024 13:03
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, works great, just a couple comment :)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested :)

@clarani clarani force-pushed the cni/8418-display-pathsteps-even-if-simulation-fails branch from bb1612a to 7dde05a Compare December 10, 2024 16:38
@clarani clarani force-pushed the cni/8418-display-pathsteps-even-if-simulation-fails branch from 7dde05a to 1d0bfdb Compare December 11, 2024 10:32
@clarani clarani force-pushed the cni/8418-display-pathsteps-even-if-simulation-fails branch from 1d0bfdb to 13fd95a Compare December 11, 2024 10:44
@clarani clarani added this pull request to the merge queue Dec 11, 2024
Merged via the queue into dev with commit 5a176ec Dec 11, 2024
27 checks passed
@clarani clarani deleted the cni/8418-display-pathsteps-even-if-simulation-fails branch December 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing path item on map for invalid train schedule
4 participants