-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: display path steps even if the simulation failed #9962
front: display path steps even if the simulation failed #9962
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9962 +/- ##
==========================================
- Coverage 80.11% 80.03% -0.09%
==========================================
Files 1048 1049 +1
Lines 105250 105293 +43
Branches 756 757 +1
==========================================
- Hits 84325 84269 -56
- Misses 20884 20983 +99
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
osrdToNge already does the exact same kind of logic. Would be nice to de-duplicate. |
4fd1cf5
to
1c93b1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, works great, just a couple comment :)
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested :)
bb1612a
to
7dde05a
Compare
Signed-off-by: Clara Ni <[email protected]>
Signed-off-by: Clara Ni <[email protected]>
… a train Signed-off-by: Clara Ni <[email protected]>
7dde05a
to
1d0bfdb
Compare
Signed-off-by: Clara Ni <[email protected]>
1d0bfdb
to
13fd95a
Compare
closes #8418