load_key: Improve key loading by label. After importing a certificate… #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on a SafeNet usb token under Windows the certificate is labeled but the key label is empty. To solve this problem, the certificate label is used instead of empty key labels to find the key. Verbose output is also updated to show the effective key label and the matching certificate serial number is also written to the trace. So the key can be identified from the log output.
mtrojnar
reviewed
Mar 20, 2021
| @@ -166,7 +166,7 @@ static int pkcs11_next_cert(PKCS11_CTX *ctx, PKCS11_TOKEN *token, | |||
| CK_OBJECT_HANDLE obj; | |||
| CK_ULONG count; | |||
| int rv; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on a SafeNet usb token under Windows the certificate is labeled but the key label is empty.
To solve this problem, the certificate label is used instead of empty key labels to find the key. Verbose output is also updated to show the effective key label and the matching certificate serial number is also written to the trace. So the key can be identified from the log output.