Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ugly formatting of warning box #212

Closed
jan-cerny opened this issue Sep 15, 2023 · 0 comments · Fixed by #219
Closed

Ugly formatting of warning box #212

jan-cerny opened this issue Sep 15, 2023 · 0 comments · Fixed by #219
Labels
bug Something isn't working

Comments

@jan-cerny
Copy link
Member

Describe the bug
The warning contains a monospaced text with gray backgrounds which spans from left to right and causes a new line, see the screenshot below.

To Reproduce
Steps to reproduce the behavior:

  1. Generate report from the attached ARF
  2. Go to rule details in rule audit_rules_privileged_commands
  3. Scroll down to warnings
  4. See the warning

ARF file
attach.zip

Expected behavior
The item with gray backgrounds doesn't span and doesn't cause a new line.

Screenshots
image

Environment (please complete the following information):

  • OS: Fedora 38
  • Browser: firefox-117.0.1-1.fc38.x86_64
  • Python version: python3-3.11.5-1.fc38.x86_64
  • Openscap-report version: openscap-report-0.2.5-1.fc38.noarch

Additional context
No.
@jan-cerny jan-cerny added the bug Something isn't working label Sep 15, 2023
@Honny1 Honny1 linked a pull request Dec 21, 2023 that will close this issue
Fix of pre element width #219
Merged
jan-cerny added a commit to jan-cerny/scap-security-guide that referenced this issue Dec 28, 2023
@jan-cerny
Use correct HTML element for inline code
cc560c7 
For inline code entries the `<code>` element should be used instead
of the `<pre>` element which is a block element.

Using an incorrect element causes inappropriate formatting across our
HTML guides and reports. This problem has been discovered during work
on issue:
OpenSCAP/openscap-report#212
@jan-cerny jan-cerny mentioned this issue Dec 28, 2023
Merged
sluetze pushed a commit to sig-bsi-grundschutz/content that referenced this issue Jan 8, 2024
@jan-cerny @sluetze
Use correct HTML element for inline code
b4d66ab 
For inline code entries the `<code>` element should be used instead
of the `<pre>` element which is a block element.

Using an incorrect element causes inappropriate formatting across our
HTML guides and reports. This problem has been discovered during work
on issue:
OpenSCAP/openscap-report#212
sluetze pushed a commit to sig-bsi-grundschutz/content that referenced this issue Jan 8, 2024
@jan-cerny @sluetze
Use correct HTML element for inline code
e752b4f 
For inline code entries the `<code>` element should be used instead
of the `<pre>` element which is a block element.

Using an incorrect element causes inappropriate formatting across our
HTML guides and reports. This problem has been discovered during work
on issue:
OpenSCAP/openscap-report#212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix of pre element width Honny1/oscap-report
1 participant
@jan-cerny