Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add cifuzz integration #2697

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

DavidKorczynski
Copy link
Contributor

Add cifuzz integration so oss-fuzz fuzzers are run 600 secs each PR

Signed-off-by: David Korczynski [email protected]

Summary

This adds CI integration with CIFuzz. CIFuzz will run the opensips OSS-Fuzz fuzzers (see this issue here #2625) for a short period of time for each PR. The benefit is that regressions and bugs has a chance of being captured early in the development process.

Details

CIFuzz is the Github action for OSS-Fuzz.

Solution

Compatibility

No compatibility issues.

Closing issues

Add cifuzz integration so oss-fuzz fuzzers are run 600 secs each PR

Signed-off-by: David Korczynski <[email protected]>
@liviuchircu liviuchircu self-assigned this Nov 25, 2021
@liviuchircu liviuchircu added this to the 3.3.0-beta milestone Nov 25, 2021
@liviuchircu
Copy link
Member

Hey, @DavidKorczynski and thanks for this! Could you make it run on every push instead of every pull_request? (I hope i got the verb right...)

The reason for this is that 90%+ of OpenSIPS contributions to master branch are made via git push, rather than by clicking "Merge Pull Request".

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Contributor Author

I added push now - I enabled both as I figured having on pull as well doesn't hurt?

Copy link
Member

@liviuchircu liviuchircu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DavidKorczynski
Copy link
Contributor Author

Argh, we are actually running into an issue here because of CIFuzz. The issue is that the fuzzers are placed in OSS-Fuzz repo rather than opensips, and CIFuzz does some stuff where it deletes the opensips repository and then reclones it, which causes the fuzzers to be removed. The issue is known (google/oss-fuzz#6755) and I have run into it with another project. I should be able to do a quick fix on the OSS-Fuzz repository. Will ping you shortly when the fix has been deployed @liviuchircu

@DavidKorczynski
Copy link
Contributor Author

It works now in my fork @liviuchircu (https://github.com/DavidKorczynski/opensips/actions) so I think it should work if you retrigger the CI

@liviuchircu liviuchircu merged commit 61eb080 into OpenSIPS:master Nov 25, 2021
@liviuchircu
Copy link
Member

That's great! Thank you, @DavidKorczynski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants