Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move main.go to subfolder under cmd #280

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

nieomylnieja
Copy link
Member

@nieomylnieja nieomylnieja commented Jan 10, 2024

Main changes

In order for go install to automatically name the binary it installs as oslo we have to create artificial folder nesting in cmd.
Currently, while go install is possible, it will create a cmd binary which will require manual renaming.

Additional changes

Corrected deprecated (and since 1.19.0 removed) Goreleaser config option --> https://goreleaser.com/deprecations/#archivesreplacements.

@nieomylnieja nieomylnieja added go Pull requests that update Go code enhancement New feature or request labels Jan 10, 2024
@nieomylnieja nieomylnieja requested a review from BSski January 10, 2024 21:00
@nieomylnieja nieomylnieja merged commit 8949daa into main Jan 12, 2024
3 checks passed
@nieomylnieja nieomylnieja deleted the move-main-to-subfolder-in-cmd branch January 12, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants