Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] spp_change_request_create_farm: Create Module #699

Merged
merged 19 commits into from
Feb 18, 2025

Conversation

emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Jan 2, 2025

Why is this change needed?

To add creation change requests for group and farms which includes all fields for group and individuals.

How was the change implemented?

Added 2 modules, one for CR Create Group and one for CR Create Farm

New unit tests

TestChangeRequestCreateGroup
TestChangeRequestCreateFarm

Unit tests executed by the author

TestChangeRequestCreateGroup
TestChangeRequestCreateFarm

How to test manually

  • Install or Update spp_change_request_create_group or spp_change_request_create_farm on respective instance. (First one is for SPMIS Instance and other is for Farmer Instance)
  • Create a Change Request for the installed Change Request.
  • Go through with it and apply.

Related links

#681

@emjay0921 emjay0921 linked an issue Jan 2, 2025 that may be closed by this pull request
3 tasks
@emjay0921 emjay0921 marked this pull request as ready for review January 6, 2025 01:28
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 86.08696% with 32 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (9d21f2d) to head (e500a92).
Report is 41 commits behind head on 17.0.

Files with missing lines Patch % Lines
...t_create_farm/models/change_request_create_farm.py 80.53% 13 Missing and 16 partials ⚠️
...eate_farm/tests/test_change_request_create_farm.py 96.61% 1 Missing and 1 partial ⚠️
.../change_request_create_farm_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #699      +/-   ##
==========================================
+ Coverage   75.80%   75.94%   +0.14%     
==========================================
  Files         706      713       +7     
  Lines       17906    18136     +230     
  Branches     2225     2255      +30     
==========================================
+ Hits        13574    13774     +200     
- Misses       3869     3882      +13     
- Partials      463      480      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emjay0921 emjay0921 changed the title 681 create cr type create group [ADD] spp_change_request_create_farm: Create Module Jan 9, 2025
@gonzalesedwin1123 gonzalesedwin1123 merged commit 62b57fe into 17.0 Feb 18, 2025
7 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 681-create-cr-type-create-group branch February 18, 2025 06:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CR type create-group
3 participants