Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the Change Request base module to make it OpenSPP independent #736

Draft
wants to merge 10 commits into
base: 17.0
Choose a base branch
from

Conversation

gonzalesedwin1123
Copy link
Member

Why is this change needed?

The current spp_change_request module is dependent on OpenG2P and OpenSPP base modules. There is a need for the change request base module to be used in other implementations where OpenG2P and/or OpenSPP is not needed.

How was the change implemented?

A new spp_change_request_base module was developed and will be the parent module for all change request type modules. Implementation-specific requirements for change request can now be handled in the change request type modules.

New unit tests

Unit tests executed by the author

How to test manually

Related links

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Jan 30, 2025 that may be closed by this pull request
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
36.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 46.38889% with 386 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (d50ba4c) to head (3c56bcf).
Report is 92 commits behind head on 17.0.

Files with missing lines Patch % Lines
..._change_request_base/models/mixins/source_mixin.py 19.40% 191 Missing ⚠️
spp_change_request_base/models/change_request.py 51.00% 110 Missing and 12 partials ⚠️
...nge_request_base/wizard/confirm_user_assignment.py 45.83% 26 Missing ⚠️
...hange_request_base/wizard/cancel_change_request.py 42.85% 15 Missing and 1 partial ⚠️
...hange_request_base/wizard/reject_change_request.py 48.14% 13 Missing and 1 partial ⚠️
...st_base/models/mixins/validation_sequence_mixin.py 50.00% 9 Missing ⚠️
spp_change_request_base/models/dms_file.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #736      +/-   ##
==========================================
- Coverage   76.23%   74.66%   -1.57%     
==========================================
  Files         687      723      +36     
  Lines       17777    18626     +849     
  Branches     2205     2351     +146     
==========================================
+ Hits        13552    13907     +355     
- Misses       3774     4241     +467     
- Partials      451      478      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to Change Request module
1 participant