-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the Change Request base module to make it OpenSPP independent #736
base: 17.0
Are you sure you want to change the base?
Conversation
…to be OpenSPP independent
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 17.0 #736 +/- ##
==========================================
- Coverage 76.23% 74.66% -1.57%
==========================================
Files 687 723 +36
Lines 17777 18626 +849
Branches 2205 2351 +146
==========================================
+ Hits 13552 13907 +355
- Misses 3774 4241 +467
- Partials 451 478 +27 ☔ View full report in Codecov by Sentry. |
Why is this change needed?
The current spp_change_request module is dependent on OpenG2P and OpenSPP base modules. There is a need for the change request base module to be used in other implementations where OpenG2P and/or OpenSPP is not needed.
How was the change implemented?
A new spp_change_request_base module was developed and will be the parent module for all change request type modules. Implementation-specific requirements for change request can now be handled in the change request type modules.
New unit tests
Unit tests executed by the author
How to test manually
Related links