Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance motion fields #844

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Enhance motion fields #844

merged 8 commits into from
Feb 15, 2024

Conversation

jsangmeister
Copy link
Contributor

@jsangmeister jsangmeister added this to the 4.2 milestone Feb 12, 2024
@jsangmeister jsangmeister self-assigned this Feb 12, 2024
This was referenced Feb 12, 2024
Merged
Closed
@jsangmeister jsangmeister changed the title Update generated files Enhance motion fields Feb 12, 2024
@jsangmeister jsangmeister assigned ostcar and unassigned jsangmeister Feb 12, 2024
@jsangmeister
Copy link
Contributor Author

@ostcar The changes from OpenSlides/openslides-meta#26 have to reflected in the autoudate service, namely implementing the new collections. They should behave exactly the same as motion_submitter, so you should be able to simply refactor & recycle the code. Can you do this?

@jsangmeister
Copy link
Contributor Author

Interestingly, the new feature works even without these changes. Does the autoupdate service simply pipe through unkown collections?

@jsangmeister jsangmeister linked an issue Feb 13, 2024 that may be closed by this pull request
Enhance new motion fields #845
Closed
@bastianjoel bastianjoel marked this pull request as draft February 14, 2024 10:15
@bastianjoel bastianjoel assigned bastianjoel and unassigned ostcar Feb 14, 2024
@bastianjoel
Copy link
Member

So a motion with state restriction is_submitter should be visible to a user if the user is an editor? Is this correct? @emanuelschuetze

@jsangmeister
Copy link
Contributor Author

So a motion with state restriction is_submitter should be visible to a user if the user is an editor? Is this correct? @emanuelschuetze

talked with @emanuelschuetze: No, there should be no changes to the visibility of a motion for editors/working group speakers

@jsangmeister jsangmeister marked this pull request as ready for review February 14, 2024 13:26
ostcar
ostcar requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ostcar ostcar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a draft until the changes to meta was merged into its main branch.

If there is a PR (not a draft PR) that looks good, then I think, that I should merge it.

internal/restrict/collection/motion_editor.go Outdated Show resolved Hide resolved
internal/restrict/collection/motion_editor.go Outdated Show resolved Hide resolved
internal/restrict/collection/motion_working_group_speaker.go Outdated Show resolved Hide resolved
emanuelschuetze
emanuelschuetze previously requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this PR (together with client and backend). There is an error after trying to login with a normal user (superadmin works)!

autoupdate-1        | 2024/02/15 06:52:33 http: panic serving 172.21.0.14:36924: runtime error: invalid memory address or nil pointer dereference

@ostcar
Copy link
Member

ostcar commented Feb 15, 2024

I cannot test this PR (together with client and backend). There is an error after trying to login with a normal user (superadmin works)!

autoupdate-1        | 2024/02/15 06:52:33 http: panic serving 172.21.0.14:36924: runtime error: invalid memory address or nil pointer dereference

Are you sure, that this is the only error message? When there is a panic, there should be a lot of lines in the error log

@bastianjoel
Copy link
Member

I cannot replicate this

@jsangmeister
Copy link
Contributor Author

I cannot replicate this

Me neither

@jsangmeister jsangmeister merged commit 82c7d35 into OpenSlides:main Feb 15, 2024
2 checks passed
@jsangmeister jsangmeister deleted the enhance-motion-fields branch February 15, 2024 09:35
peb-adr added a commit that referenced this pull request Mar 12, 2024
@peb-adr
Merge staging/4.1.3 into stable/4.1.x. Update 20240312
e5b6802 
* commit '441c4d9b6e7aff5f82baa8bbbdde05240e6436f8': (27 commits)
  Update meta repository (#885)
  Update meta (#877)
  Automatically create PRs for commits on staging branches (#865)
  Change restricter for motion_change_recommendation (#857)
  Bump github.com/klauspost/compress from 1.17.6 to 1.17.7 (#856)
  Remove update-generated-files.yml (#854)
  Update meta repository (#853)
  Bump github.com/gomodule/redigo from 1.8.9 to 1.9.1 (#852)
  new settings for one participant multiple times in the LoS (#851)
  Add identical motions (#846)
  Enhance motion fields (#844)
  Update go version (#850)
  Add motion restriction mode for `is_internal` (#847)
  Unify name of the openslides-meta submodule (#843)
  Add new restrictions for LoS extension (#807) (#810)
  Update meta repository (#841)
  Bump golang.org/x/sys from 0.16.0 to 0.17.0 (#839)
  Bump github.com/klauspost/compress from 1.17.5 to 1.17.6 (#836)
  Use models.yml from meta repo (#834)
  Bump github.com/jackc/pgx/v5 from 5.5.2 to 5.5.3 (#835)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostcar ostcar ostcar approved these changes

@emanuelschuetze emanuelschuetze emanuelschuetze left review comments

Assignees

@bastianjoel bastianjoel

Labels
feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Enhance new motion fields
4 participants
@jsangmeister @bastianjoel @ostcar @emanuelschuetze