-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yaml #849
Merged
Merged
Yaml #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsangmeister
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my amateur perspective if it works. @bastianjoel could you do the same for the search service?
bastianjoel
approved these changes
Feb 28, 2024
peb-adr
added a commit
to peb-adr/openslides-autoupdate-service
that referenced
this pull request
Mar 20, 2024
* commit '8804946fdca03dc3c30dd92f0a4667833113059c': (24 commits) Update meta repository (OpenSlides#891) Update meta repository (OpenSlides#889) Bump github.com/jackc/pgx/v5 from 5.5.4 to 5.5.5 (OpenSlides#886) Update meta repository (OpenSlides#887) Bump github.com/alecthomas/kong from 0.8.1 to 0.9.0 (OpenSlides#884) Update meta repository (OpenSlides#881) Bump golang from 1.22.0-alpine to 1.22.1-alpine (OpenSlides#883) Automatically close feature branch issues (OpenSlides#882) Bump golang.org/x/sys from 0.17.0 to 0.18.0 (OpenSlides#879) Bump github.com/jackc/pgx/v5 from 5.5.3 to 5.5.4 (OpenSlides#880) Update meta repository (OpenSlides#878) Add free text submitter field (OpenSlides#864) Update meta repository (OpenSlides#875) Add Maybe-Type for non required fields (OpenSlides#872) Fixes requests from anonymous user (OpenSlides#873) Yaml (OpenSlides#849) Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (OpenSlides#871) Update meta repository (OpenSlides#869) Update meta repository (OpenSlides#868) Automatically create PRs for commits on staging branches (OpenSlides#865) (OpenSlides#867) ...
bastianjoel
pushed a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new yaml lib. It seems to work.
@jsangmeister and @bastianjoel Is this the way to go? I don't see any harm in mergin it.