Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a structure level list component and basic stuff for structure level #3011

Merged
merged 30 commits into from
Dec 15, 2023
Merged

Add a structure level list component and basic stuff for structure level #3011

merged 30 commits into from
Dec 15, 2023

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Nov 13, 2023

Includes a draft version of model, view-model, repo, controller, and subdivision-list.

@reiterl reiterl added this to the 4.2 milestone Nov 13, 2023
@reiterl reiterl changed the base branch from main to feature/los-extension November 13, 2023 13:48
@reiterl reiterl changed the title Add a subdivision list component and basic stuff for subdivision Add a structure level list component and basic stuff for structure level Nov 15, 2023
@reiterl
Copy link
Member Author

reiterl commented Nov 15, 2023

Includes a draft version of structure level list.

luisa-beerboom
luisa-beerboom requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're still missing some fields in the structure level, the meeting_user_ids for example.

You should also mirror the id fields in the referencing models and add the corresponding entries in the relations.ts

@reiterl
Copy link
Member Author

reiterl commented Nov 16, 2023

Yes, the model is not completed. I need to work on that too.

@reiterl reiterl requested a review from bastianjoel November 23, 2023 10:52
@reiterl reiterl removed their assignment Dec 14, 2023
@bastianjoel bastianjoel marked this pull request as ready for review December 15, 2023 12:05
@bastianjoel bastianjoel merged commit 1bc9ae5 into OpenSlides:feature/los-extension Dec 15, 2023
@reiterl reiterl deleted the subdivisions-list branch January 4, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom Awaiting requested review from luisa-beerboom

@bastianjoel bastianjoel Awaiting requested review from bastianjoel

Assignees

@bastianjoel bastianjoel

Labels
feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@reiterl @bastianjoel @luisa-beerboom