Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PRs in all depending repos #25

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Create PRs in all depending repos #25

merged 7 commits into from
Feb 22, 2024

Conversation

jsangmeister
Copy link
Contributor

@jsangmeister jsangmeister commented Feb 9, 2024 •
edited
Loading

resolves #23

@jsangmeister jsangmeister added feature waiting Waiting for some other PR/feature; more details in comments labels Feb 9, 2024
@jsangmeister jsangmeister added this to the 4.2 milestone Feb 9, 2024
@jsangmeister jsangmeister self-assigned this Feb 9, 2024
@jsangmeister jsangmeister mentioned this pull request Feb 13, 2024
Closed
@jsangmeister jsangmeister removed the waiting Waiting for some other PR/feature; more details in comments label Feb 21, 2024
@jsangmeister
Copy link
Contributor Author

Changed the structure so the this repository handles the PR creation and file updates. This reduces the overhead in other repos, although one could argue that the meta repo should not have to care about how the autoupdate service generates its files, but I think it's okay to do it this way.

@jsangmeister jsangmeister requested a review from peb-adr February 21, 2024 16:59
@jsangmeister jsangmeister assigned peb-adr and unassigned jsangmeister Feb 21, 2024
peb-adr
peb-adr approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@peb-adr peb-adr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tad bit skeptical about some hardcoded values and usernames, but making it dynamic is probably not worth the effort.

@jsangmeister jsangmeister merged commit 4582665 into OpenSlides:main Feb 22, 2024
2 checks passed
@jsangmeister jsangmeister deleted the create-pr-workflow branch February 22, 2024 12:56
@jsangmeister jsangmeister mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peb-adr peb-adr peb-adr approved these changes

Assignees

@peb-adr peb-adr

@jsangmeister jsangmeister

Labels
feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Open pull requests in all related repositories after an update
2 participants
@jsangmeister @peb-adr