Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 2 pyproject toml and linter #102

Closed
wants to merge 11 commits into from

Conversation

stellaprins
Copy link
Collaborator

No description provided.

@pgleeson
Copy link
Member

@stellaprins This is useful for applying consistent formatting to the python scripts. The formatting shouldn't really be applied to auto generated XML or python files though, or files taken verbatim from external resources. We can discuss in the meeting though.

@stellaprins
Copy link
Collaborator Author

@robertvi @pgleeson are there any .py files in the SBMLShowcase rep taken verbatim from other sources?

@pgleeson
Copy link
Member

I think tyhe main ones to ignore are in the Brian and NEURON folders. Basically anything you or Rob haven't added/updated should probably be left as is.

@pgleeson
Copy link
Member

@stellaprins Looks like there's been over 5000 new files in a recent commit. Assume that wasn't intended. Wouldn't be good to get this integrated with development/main. It may even be best to remove the offending commit from the commit history..?

@stellaprins
Copy link
Collaborator Author

stellaprins commented Dec 13, 2024

@pgleeson I'm working out whether I can fit the repo into the UCL ARC recommended template for Python projects using cookiecutter and probably have accidentily commited some local files that should have been ignored by git!

Yep, won't merge these into dev. I'll undo the commit (or start a fresh branch and remove this one).

@pgleeson
Copy link
Member

Ok, great. Glad to see a nice comprehensive template for a full Python project at ARC. Note not everything there is probably required as this repo is not intended as a pip installable package, just whatever will make a cleaner simpler set of files.

@stellaprins stellaprins deleted the feat-2-pyproject-toml-and-linter branch December 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants