Update data management #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmgaudecker
reviewed
Jul 15, 2024
src/template_project/data_management/stats4schools_smoking_template.py
Outdated
Show resolved
Hide resolved
src/template_project/data_management/stats4schools_smoking_template.py
Outdated
Show resolved
Hide resolved
src/template_project/data_management/stats4schools_smoking_template.r
Outdated
Show resolved
Hide resolved
src/template_project/data_management/stats4schools_smoking_template.r
Outdated
Show resolved
Hide resolved
src/template_project/data_management/task_data_management_template.py
Outdated
Show resolved
Hide resolved
Thank you! Besides the clear signs of my inattention, the comments regarding the Hopefully, this is sufficiently bug-free now. |
hmgaudecker
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Excellent, thanks! I think we can simplify further now that we explicitly write down the formula -- no need to carry along the model_type (my comment before still left room for confusion, btw, because we usually mean by linear_index "linear in the parameters" but the formula implied "linear in the variables").
hmgaudecker
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I
functional data managementstyle we teach in EPP