Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcollector.py line 814 and line 838 #305

Closed
erdeerdeerde opened this issue Mar 18, 2016 · 4 comments
Closed

tcollector.py line 814 and line 838 #305

erdeerdeerde opened this issue Mar 18, 2016 · 4 comments
Labels
Milestone

Comments

@erdeerdeerde
Copy link

If installed via debian package, starting tcollector fails because in line 814 a file is included (from collectors.etc import config) which is not under the path of the tcollector.py executable (/usr/bin/tcollector as opposed to /usr/lib/tcollector/)

I also noticed that when the exception is thrown in line 815, the following code also fails because in line 837 a variable is referenced that has not previously been assigned a value.

@johann8384 johann8384 added the bug label Mar 21, 2016
@johann8384 johann8384 added this to the 1.3.1 milestone Mar 21, 2016
@johann8384
Copy link
Member

It sounds like we need to modify the Python path there. I will investigate.

@johann8384
Copy link
Member

Can you send me a link to the lines you are mentioning? Line 837 in my editor is:
https://github.com/OpenTSDB/tcollector/blob/master/tcollector.py#L837
'logfile': '/var/log/tcollector.log',

@erdeerdeerde
Copy link
Author

https://github.com/OpenTSDB/tcollector/blob/master/tcollector.py#L814
and
https://github.com/OpenTSDB/tcollector/blob/master/tcollector.py#L838

On 03/21/2016 08:49 PM, Jonathan Creasy wrote:

Can you send me a link to the lines you are mentioning? Line 837 in
my editor is:
https://github.com/OpenTSDB/tcollector/blob/master/tcollector.py#L837

'logfile': '/var/log/tcollector.log',

--- You are receiving this because you authored the thread. Reply
to this email directly or view it on GitHub:
#305 (comment)

@johann8384
Copy link
Member

Sorry, that was obvious, I just wanted to make sure I was looking at the right problem. I made a patch, I'll try and get time to test it. I have a few other things to test on Debian priori to the 1.3.1 release. I'm also hoping to have deb packages, not just rpm, for that one.

johann8384 added a commit that referenced this issue Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants