Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GitLab integration #171

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Refactor GitLab integration #171

merged 8 commits into from
Nov 7, 2024

Conversation

Ndpnt
Copy link
Member

@Ndpnt Ndpnt commented Nov 7, 2024

Thanks @fabianospinelli to the work done in #168 to support GitLab.

This PR refactors the initial implementation to reduce the code duplication.

@Ndpnt Ndpnt merged commit 7455a28 into main Nov 7, 2024
1 check passed
@Ndpnt Ndpnt deleted the support-gitlab branch November 7, 2024 16:20
@Ndpnt Ndpnt restored the support-gitlab branch November 7, 2024 16:55
@Ndpnt
Copy link
Member Author

Ndpnt commented Nov 12, 2024

@alessandrozago Could you please review and confirm that this works as expected? Your validation would be greatly appreciated!

@Ndpnt
Copy link
Member Author

Ndpnt commented Nov 18, 2024

Hi @alessandrozago, just following up on my earlier message. Have you had a chance to review it?

@alessandrozago
Copy link
Contributor

Hi @alessandrozago, just following up on my earlier message. Have you had a chance to review it?

Hi @Ndpnt , sorry for the late response. We are looking into it, and we will test it as much as we can. Thank you

@alessandrozago
Copy link
Contributor

Hi @Ndpnt , we were able to test the tool for GitLab, and we found just one issue for the "Edit a document declaration" functionality. The functions getProjectId and getModifiedFilesInCommit in the GitLab module do not provide an authentication token in the headers. This means that if the "versions" repository is public it works, but if the repository is private it will not be able to retrieve the information needed.
One possible solution would be to provide an additional token for the versions repository in the env file, similar to what has been done on the engine with a separate token for the releases repository.
Please let me know if you need some other information.

@Ndpnt
Copy link
Member Author

Ndpnt commented Nov 20, 2024

Hi @alessandrozago and thanks for your tests and insights!
I think the solution you suggest, i.e. to do something similar to what has been done on the engine, seems to be a good solution. Would you be able to suggest a PR to fix this issue?

@alessandrozago
Copy link
Contributor

Hi @alessandrozago and thanks for your tests and insights! I think the solution you suggest, i.e. to do something similar to what has been done on the engine, seems to be a good solution. Would you be able to suggest a PR to fix this issue?

Hi @Ndpnt . Ok, I will proceed in creating the Pull Request with this fix. Please let me know if I should also open an issue, or if this discussion is enough.

@Ndpnt
Copy link
Member Author

Ndpnt commented Nov 21, 2024

Hi @alessandrozago and thanks for your tests and insights! I think the solution you suggest, i.e. to do something similar to what has been done on the engine, seems to be a good solution. Would you be able to suggest a PR to fix this issue?

Hi @Ndpnt . Ok, I will proceed in creating the Pull Request with this fix. Please let me know if I should also open an issue, or if this discussion is enough.

Hi @alessandrozago, this discussion is enough. Thanks for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants