-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitLab integration #171
Conversation
@alessandrozago Could you please review and confirm that this works as expected? Your validation would be greatly appreciated! |
Hi @alessandrozago, just following up on my earlier message. Have you had a chance to review it? |
Hi @Ndpnt , sorry for the late response. We are looking into it, and we will test it as much as we can. Thank you |
Hi @Ndpnt , we were able to test the tool for GitLab, and we found just one issue for the "Edit a document declaration" functionality. The functions getProjectId and getModifiedFilesInCommit in the GitLab module do not provide an authentication token in the headers. This means that if the "versions" repository is public it works, but if the repository is private it will not be able to retrieve the information needed. |
Hi @alessandrozago and thanks for your tests and insights! |
Hi @Ndpnt . Ok, I will proceed in creating the Pull Request with this fix. Please let me know if I should also open an issue, or if this discussion is enough. |
Hi @alessandrozago, this discussion is enough. Thanks for asking. |
Thanks @fabianospinelli to the work done in #168 to support GitLab.
This PR refactors the initial implementation to reduce the code duplication.