Revert all === comparison with db models;

OpenUserJS · Dec 2, 2014 · 59a68a0 · 59a68a0
1 parent a9668ad
commit 59a68a0
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/controllers/scriptStorage.js b/controllers/scriptStorage.js
@@ -268,7 +268,7 @@ exports.storeScript = function (aUser, aMeta, aBuf, aCallback, aUpdate) {
     if (!scriptName) { return aCallback(null); }
 
     if (!isLibrary && aMeta.oujs && aMeta.oujs.author
-        && aMeta.oujs.author !== aUser.name && aMeta.oujs.collaborator) {
+        && aMeta.oujs.author != aUser.name && aMeta.oujs.collaborator) {
       collaborators = aMeta.oujs.collaborator;
       if ((typeof collaborators === 'string'
           && collaborators === aUser.name)
@@ -327,8 +327,8 @@ exports.storeScript = function (aUser, aMeta, aBuf, aCallback, aUpdate) {
       } else {
         // Script already exists.
         if (!aScript.isLib) {
-          if (collaborators && (aScript.meta.oujs && aScript.meta.oujs.author !== aMeta.oujs.author
-              || (aScript.meta.oujs && JSON.stringify(aScript.meta.oujs.collaborator) !==
+          if (collaborators && (aScript.meta.oujs && aScript.meta.oujs.author != aMeta.oujs.author
+              || (aScript.meta.oujs && JSON.stringify(aScript.meta.oujs.collaborator) !=
              JSON.stringify(aMeta.oujs.collaborator)))) {
             return aCallback(null);
           }

diff --git a/controllers/user.js b/controllers/user.js
@@ -1371,7 +1371,7 @@ function getExistingScript(aReq, aOptions, aAuthedUser, aCallback) {
         aOptions.source = Buffer.concat(bufs).toString('utf8');
         aOptions.original = aScript.installName;
         aOptions.url = aReq.url;
-        aOptions.owner = aAuthedUser && (aScript._authorId === aAuthedUser._id
+        aOptions.owner = aAuthedUser && (aScript._authorId == aAuthedUser._id
           || collaborators.indexOf(aAuthedUser.name) > -1);
         aOptions.username = aAuthedUser ? aAuthedUser.name : null;
         aOptions.isLib = aScript.isLib;

diff --git a/libs/flag.js b/libs/flag.js
@@ -26,7 +26,7 @@ function flaggable(aModel, aContent, aUser, aCallback) {
   // to police the site administration
   if (aModel.modelName === 'User') {
     return getFlag(aModel, aContent, aUser, function (aFlag) {
-      aCallback(aContent._id !== aUser._id && aContent.role > 2, aContent, aFlag);
+      aCallback(aContent._id != aUser._id && aContent.role > 2, aContent, aFlag);
     });
   }
 

diff --git a/libs/modelParser.js b/libs/modelParser.js
@@ -327,7 +327,7 @@ var parseDiscussion = function (aDiscussionData) {
   var recentCommentors = [];
   if (discussion.author)
     recentCommentors.push(discussion.author);
-  if (discussion.lastCommentor !== discussion.author)
+  if (discussion.lastCommentor != discussion.author)
     recentCommentors.push(discussion.lastCommentor);
   recentCommentors = _.map(recentCommentors, function (aUsername) {
     return {

diff --git a/libs/remove.js b/libs/remove.js
@@ -31,7 +31,7 @@ function removeable(aModel, aContent, aUser, aCallback) {
   // You can't remove yourself
   // You can only remove a remove a user with a lesser role than yourself
   if (aModel.modelName === 'User') {
-    return aCallback(aContent._id !== aUser._id && aContent.role > aUser.role,
+    return aCallback(aContent._id != aUser._id && aContent.role > aUser.role,
       aContent);
   }