Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the comment editor #1197

Closed
Martii opened this issue Oct 23, 2017 · 0 comments · Fixed by #1204
Closed

Embed the comment editor #1197

Martii opened this issue Oct 23, 2017 · 0 comments · Fixed by #1204
Labels
UI Pertains inclusively to the User Interface.
Milestone

Comments

@Martii
Copy link
Member

Martii commented Oct 23, 2017

As @sizzlemctwizzle mentioned a while back embed the comment editor similar to GH.

This should be done before #601 and #735 e.g. as they are dependent upon this.

Pros:

  • Older browsers, such as the Sony PS3, some "smart" phone apps, etc. (people do use internet appliances rather than a real machine), don't currently support the popup method. Just like here on GH with the popdown to logout... quite a nuisance for testing.
  • Can allow reuse for Consider Ability to Edit Comments/Discussions #601 just like GH e.g. you can edit multiple posts including new ones all at the same time.
  • On portable devices, even new ones, the popup blocks most of the page content especially when an on screen keyboard takes over a large portion of the viewport. Scrolling with touch on a very small area is not pleasant. Desktops usually don't have this issue. This is the most important reason.

Cons:

@Martii Martii added the UI Pertains inclusively to the User Interface. label Oct 23, 2017
@Martii Martii added this to the #601 milestone Oct 23, 2017
@Martii Martii self-assigned this Oct 26, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 27, 2017
* Few minor HTML fixes
* Rewrote client side script to not be in jQuery. Polyfill for older browsers.. applies to OpenUserJS#904
* Reference FAQ and GFM

Closes OpenUserJS#1197
Martii added a commit that referenced this issue Oct 27, 2017
* Few minor HTML fixes
* Rewrote client side script to not be in jQuery. Polyfill for older browsers.. applies to #904
* Reference FAQ and GFM

Closes #1197

Auto-merge
@Martii Martii removed their assignment Oct 27, 2017
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI Pertains inclusively to the User Interface.
Development

Successfully merging a pull request may close this issue.

1 participant