My CC BY-NC-SA licence is not detected (MIT displayed)

[jesus2099]

I see MIT licence on all my scripts although I think they are all using a CC BY-NC-SA licence in their metadata.
It was detected in userscripts.org.

[Martii]

Thanks for the report. Give me a moment and I'll try to see what's going on...

CONFIRMED but the JavaScript routine is working well. I think there may be a glitch in the DB storage cached values @sizzlemctwizzle and should probably be regenerated with the changes from both #174 and #161 ... thankfully I don't think there are any more upmixes to be performed at this time.

@jesus2099
Try editing one of the affected scripts... add a return or something at the end of the file or something... let me know which one and if this solves your issue... I copied your metadata block over and it's working as expected... when I hear back from you and this issue is closed I will delete any script pages I created with your metadata block.

[jesus2099]

OK great, my scripts will automatically update correctly as this one that I have updated in github today. :)
Can I force the update without loosing the github webhook sync for the other scripts ?

[sizzlemctwizzle]

You can't lose the webhook. You'd have to remove it from the repo. What do
you mean by force?
On Jun 16, 2014 3:16 PM, "PATATE12" [email protected] wrote:

OK great, my scripts will automatically update correctly as this one
https://openuserjs.org/scripts/jesus2099/httpsgithub.comjesus2099konami-command/mb._MASS_MERGE_RECORDINGS
that I have updated in githubg today. :)
Can I force the update without loosing the github webhook sync for the
other scripts ?

—
Reply to this email directly or view it on GitHub
#175 (comment)
.

[Martii]

Can I force the update ... ?

Not sure... you might try resending your most recent webhook events... that might trigger a refresh on OUJS... same should go with resyncing it via reimporting with more of an assumed chance of refreshing. Please let us know the results. :)

[jesus2099]

I clicked Edit scripts then Submit code on that one, it worked. I hope the webhook will still update that script if i ever change it on github.
I will try same thing right before next time I want to update another one.

[Martii]

I hope the webhook will still update that script if i ever change it on github.

Again not sure but you can try updating the one on your GH repo and see if it still does Sure now... see GH here and OUJS here. I edited on OUJS first (was @version 0.0.1) then edited in my local repo and pushed it to GH and OUJS did keep sync. (now @version 0.0.2)

If you want to just reimport all your scripts back in... that should be the easiest if you don't know how to resend the webhook.

[sizzlemctwizzle]

Yes the webhook will continue to work, even if you update a script on the
site via other means.

Essentially the responsible code receives a list of files you modified on
GitHub and updates any matching scripts of yours on the site.
On Jun 16, 2014 4:24 PM, "PATATE12" [email protected] wrote:

I clicked Edit scripts then Submit code on that one
https://openuserjs.org/scripts/jesus2099/httpsgithub.comjesus2099konami-command/last.fm._ALL_LINKS_TO_LOCAL_SITE,
it worked. I hope the webhook will still update that script if i ever
change it on github.
I will try same thing right before next time I want to update another one.

—
Reply to this email directly or view it on GitHub
#175 (comment)
.

[Martii]

@sizzlemctwizzle

You'll probably still need to write something to fix (reconcile) the cached metadata base for those users that are pasting/uploading ... that is out of my league right now esp. without known access. Assigning to you. The longer we wait on this the more chance that #174 will generate this issue down the line too... so tagged that one with "sooner". Since we're still relatively low on script counts compared to USO I don't think it will take long.

---

@cletusc has a pending sync commit that may be affected too.

[sizzlemctwizzle]

You'll probably still need to write something to fix (reconcile) the cached metadata base for those users that are pasting/uploading ...

New metadata overwrites the old. The metadata is what we got from the current version of the script on the site. They should always match.

[Martii]

They should always match.

Firstly they don't because of the routine that was imported from CI... it splits on spaces (\s+), trims and rewrites as cleanly as possible on values... that way we don't end up with "shoes" messages (spam) in the metadata block like USO does with that meta.js routine.

Secondlly the "upmix", as I word it, actually does minimal transformation to certain key names e.g. @licence to @license for the meta routine. When you use Meta View on this script you can see it and our site code doesn't become bloated with larger merge routines to maintain.

The meta routine is however "nearly identical" :)

New metadata overwrites the old.

Self correcting is a good thing. :) You don't have to correct the DB but it will probably be an annoyance for those experiencing this... We could just tell 'em to resync, resend webhook, or update their scripts to fix it... e.g. put the ball in their court.

Based on this info what do you want me to do? Close this issue or rewrite a potentially CPU/MEM intensive merge routine (this is a reason why I opted out of it in CI because that script already eats a lot of cycles and upmixing is definitely the faster track) ??

---

Btw these upmixes currently only affect approximately 6.9% of our Script Authors or higher leveled user base... future update/uploads/pastes/syncs of course won't be affected. :)

[sizzlemctwizzle]

Tell users to re-upload (or whatever appropriate) their scripts if they
want their metadata fixed. We're not going to re-parse every script's meta
everytime we make an improvement.

[Martii]

users to re-upload

Okie dokie. Closing.

[jesus2099]

Is telling all users easier ? Don’t forget to do so. :)

[sizzlemctwizzle]

We can post a message on the site.
On Jun 18, 2014 12:36 AM, "PATATE12" [email protected] wrote:

Is telling all users easier ? Don’t forget to do so. :)

—
Reply to this email directly or view it on GitHub
#175 (comment)
.

[Martii]

Is telling all users easier

Matter of perspective. ;)

Don’t forget to do so.

It's these users scripts from a manual audit (Reaudited a 2nd time):

• https://openuserjs.org/users/BitTorrentse/scripts (@homepage issue)
• https://openuserjs.org/users/elundmark/scripts (@homepage issue)
• https://openuserjs.org/users/halukilhan/scripts (@homepage issue)
• https://openuserjs.org/users/jerone/scripts (@homepage issue)
• https://openuserjs.org/users/jesus2099/scripts (@licence issue)
• https://openuserjs.org/users/mental/scripts (@homepage issue)
• https://openuserjs.org/users/Owyn/scripts (@homepage issue)
• https://openuserjs.org/users/reek/scripts (@homepage issue)
• https://openuserjs.org/users/solygen/scripts (@homepage issue)
• https://openuserjs.org/users/tumpio/scripts (@homepage issue)

We can strike out two notifications since you are here and here is notifying @jerone if he hasn't been following... so that makes a whole 8 to notify to check. :) Not all are @licence related. Jerone has both @homepage and @homepageURL so only one is showing until he updates next.

---

So only ones found with @licence issue are:

• https://openuserjs.org/users/jesus2099/scripts

and one other that didn't have @license or @licence defined but using a license header... which should be compatible with the site default... starts out with site default then moves to user specified which can override... I'd much rather people use at least the @license/@licence though.

So we are down to a massive 1ish users to notify. ;) (sorry for the re-edits but verifying again and these are bound to change at some point and manually is time consuming)

I do appreciate greatly your reporting @jesus2099 . :)

[jesus2099]

Wow, thanks @Martii for finding out it’s eventually this limited ! :D

[jerone]

here is notifying @jerone

Noted 😄