Broader downloadURL check
#1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix someone who did an OUJS script homepage for a `downloadURL`... should cover any other non-Userscript-source route. Previous meta check is inclusive since that's not a Userscript source route. Post fix for OpenUserJS#944 and OpenUserJS#1004 change
Martii
added
enhancement
|
Hmmm not sure if I like how it drops the PR summary and only goes off of the squash commit summary. Would be nice if it auto copied it from all the Commits and PR master summary... even if it was just in the squash merge summary textarea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloadURL... should cover any other non-Userscript-source route. Previous meta check is inclusive since that's not a Userscript source route.Post fix for #944 and #1004 change