Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try a rolling session middleware #1244

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Try a rolling session middleware #1244

merged 1 commit into from
Nov 9, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 9, 2017 •
edited
Loading

  • Alternative is "Remember me" option although I think I'd rather have a "Forget me" option by default.

Post #1202 and related to #604

May have missed putting in a aReq.session.touch(); here... probably for server side but client side does change the cookie expiration.

@Martii
Try a rolling session middleware
1ed7aeb 
* Alternative is "Remember me" option although I think I'd rather have a "Forget me" option by default.

Post OpenUserJS#1202 and related to OpenUserJS#604
@Martii Martii added CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical. labels Nov 9, 2017
@Martii Martii merged commit 12e4b76 into OpenUserJS:master Nov 9, 2017
@Martii Martii deleted the rollingSessionMiddleware branch November 9, 2017 08:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. security Usually relates to something critical.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii