Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statusCodePage enhance further #1289

Merged
merged 1 commit into from
Nov 28, 2017
Merged

statusCodePage enhance further #1289

merged 1 commit into from
Nov 28, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 28, 2017

  • Use some more bootstrap classes
  • Show which file erred out on repos that have multiple scripts. (and singles)

Post #1284

@Martii
statusCodePage enhance further
5738ac7 
* Use some more *bootstrap* classes
* Show which file erred out on repos that have multiple scripts.

Post OpenUserJS#1284
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Nov 28, 2017
@Martii Martii merged commit 76f5a65 into OpenUserJS:master Nov 28, 2017
@Martii Martii deleted the statusCodePageEnhanceMore branch November 28, 2017 10:02
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Nov 28, 2017
@Martii
Fix *async* waterfall to spec in this section
cbaa4bd 
* Some Code condensing in the process as a result

NOTES:
* Some of the errors returned may still be strings instead of an Error *(subclassed or not)* so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time.

Post OpenUserJS#1284 OpenUserJS#1289 and OpenUserJS#1274 OpenUserJS#37
@Martii Martii mentioned this pull request Nov 28, 2017
Merged
Martii added a commit that referenced this pull request Nov 28, 2017
@Martii
Fix *async* waterfall to spec in this section (#1290)
decfa0e 
* Some Code condensing in the process as a result

NOTES:
* Some of the errors returned may still be strings instead of an Error *(subclassed or not)* so add default conditional for that. Usually those are 400 user errors but could be 500 server error... unknown at this time.

Post #1284 #1289 and #1274 #37

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii