Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to existing code style #1479

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Refactor to existing code style #1479

merged 1 commit into from
Jul 2, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 2, 2018

  • Should be functionally equivalent to the inline but using current structures e.g. match project code style placements. Needed for next stage.
  • Added one override on parseDateProperty since date sometimes gets written to a flat string object instead of Date.

NOTE: These are no longer sorted as that's coming up in the future... although may reinstate if lack of time

Post #1446 ... related to #604

@Martii
Refactor to existing code style
4859c4b 
* Should be functionally equivalent to the inline but using current structures e.g. match project code style placements. Needed for next stage.
* Added one override on `parseDateProperty` since `date` sometimes gets written to a flat string object instead of `Date`.

Post OpenUserJS#1446 ... related to OpenUserJS#604
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. DB Pertains inclusively to the Database operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 2, 2018
@Martii Martii merged commit ca8847c into OpenUserJS:master Jul 2, 2018
@Martii Martii deleted the refactorStyle branch July 2, 2018 05:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii