Invert the TTL value and extend to fixed #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now this is giving predictable results so far. Refs: * https://github.com/jdesboeufs/connect-mongo/blob/9f86f90/README.md#session-expiration * https://github.com/jdesboeufs/connect-mongo/blob/9f86f90/README.md#remove-expired-sessions NOTES: These versions of the docs are ambiguous. The TTL is how often it reaches out to the DB... if it finds an expired session **or** a session cookie it will then remove it. So the inversion of the logic should fix this as it checks every 10ish minutes for expiry as well as session cookies and destroys them. Had a light bulb flip on with `interval` being doc'd at 10 minutes so I thought to try TTL at that... and voila. :) This theoretically should solve OpenUserJS#604 by sticking to this methodology *(until MongoDB changes something heh)* When available will do some code condensing to reuse some more code if applicable. Post OpenUserJS#1471 ... related to OpenUserJS#604
Martii
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
NOTES:
These versions of the docs are ambiguous. The TTL is how often it reaches out to the DB... if it finds an expired session or a session cookie it will then remove it. So the inversion of the logic should fix this as it checks every 10ish minutes for expiry as well as session cookies and destroys them. Had a light bulb flip on with
intervalbeing doc'd at 10 minutes so I thought to try TTL at that... and voila. :)This theoretically should solve #604 by sticking to this methodology (until MongoDB changes something heh)
When available will do some code condensing to reuse some more code if applicable.
Post #1471 ... related to #604