Remove _since and favour created
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `_since` has a precision issue and possible extended time failure due to lack of bits * Fix a few timing issues * Best not to set default date in groups model as it can cover up errors and was doing it twice * Some identifier symmetry * All models should have base `created` with the exception of `removed` since once gone that's technically creation of nothingness. * Bump package version since older backups won't be valid after migration Applies to OpenUserJS#349
Martii
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_sincehas a precision issue and possible extended time failure due to lack of bitscreatedwith the exception ofremovedsince once gone that's technically creation of nothingness.Applies to #349