Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not minify when isDbg. #466

Merged
merged 1 commit into from
Dec 2, 2014
Merged

Do not minify when isDbg. #466

merged 1 commit into from
Dec 2, 2014

Conversation

Zren
Copy link
Contributor

@Zren Zren commented Dec 2, 2014

Also (isPro || isDev) is redundant since == (isPro || !isPro) == true.

(isPro || isDev) == (isPro || !isPro) == true
@Martii Martii added the wontfix Nope, nada, zip, zilch. label Dec 2, 2014
@Martii
Copy link
Member

Martii commented Dec 2, 2014

Currently it may appear to be redundant however since you aren't paying attention to what I just typed today this is at a -1 and not in the cards for the backend host. Conversely if you are paying attention then you are being snarky. Either way... closing. Thanks though.

@Martii Martii closed this Dec 2, 2014
@Zren
Copy link
Contributor Author

Zren commented Dec 2, 2014

paying attention to what I just typed today

Link? You spammed my inbox with +1s, so I might of missed something. Are you planning on making isDev not be !isPro?

Anyways, this PR was mostly for your benefit as you originally asked for no minification when isDbg is true, which I originally missed in the original PR. So shrug.

@Martii
Copy link
Member

Martii commented Dec 2, 2014

Are you planning on

I'm not planning on anything other than matching the current OUJS production environment... we need all three modes at every level. I hope that you can see this from the bigger picture... don't pseudo optimize when it's not finished. You can argue with me until you are blue in the face on this... sizzle is aware of what needs to be done in pro and so do I because I'm the one that mentioned it to him. Please be patient... go work on something that you assigned yourself to first... don't nit pick on something that you know won't be changing anytime soon.... I understand that node-sass via express-minify is one of your non-favorites at the moment... get over it please.

@Martii
Copy link
Member

Martii commented Dec 2, 2014

You spammed my inbox with +1s

Unfortunately that was for jerones benefit... e.g. that issue will probably be closed if he doesn't fix (reduce) it... you dismissed it again at #464 ... all of this is inclusive and if it needs a milestone say so so you don't step on anyones (mine too) toes... We already are some with jerones recent prs with sizzles work. Trying to manage all of these smart people isn't exactly easy because we all want to jump the gun... we can't do that and have viable code.

Are you planning on making isDev not be !isPro?

To strictly answer your question... Yes but certain things need to happen first including the meta discussions.

So again... please be patient.

@Martii
Copy link
Member

Martii commented Dec 2, 2014

This is compatible with some other upcoming code albeit a parallel change... so reopening since it might be more clear as well as working with existing code (which will eventually be changing)

@Martii Martii reopened this Dec 2, 2014
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. intended behavior "It's a feature not a bug." and removed wontfix Nope, nada, zip, zilch. labels Dec 2, 2014
Martii added a commit that referenced this pull request Dec 2, 2014
Do not minify when isDbg.

Slightly premature but does work with existing code and upcoming code branch. Merge.
@Martii Martii merged commit 88fd8be into OpenUserJS:master Dec 2, 2014
@Martii Martii removed the intended behavior "It's a feature not a bug." label Jan 9, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

2 participants