Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish enabling hidden QSP in User Script List pages #778

Merged
merged 1 commit into from
Oct 21, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 21, 2015

  • Turns library into a tri-state, but only on User Script List pages
  • Missed a few labels too in Enable the missing library QSP on User home pages #777
  • Commented it as much as I can for clarity for those not familiar with multi-state QSP's
  • Kept the view duplicated for clarity... does make twice the management task but this should be low-maintenance e.g. won't change much (tiny bit easier to read too with those mu2 conditionals ;)

Post #643


How this works

For everyone:

... possible addition of a nav dropdown if anyone desires.

May be modified by those with Mod permissions to include the flagged QSP with returning those lists:

... and for Admins+ when #641 is fini'd:

* Turns `library` into a tri-state, but only on User Script List pages
* Missed a few labels too in OpenUserJS#777
* Commented it as much as I can for clarity for those not familiar with multi-state QSP's
* Kept the view duplicated for clarity... does make twice the management task but this should be low-maintenance e.g. won't change much

Post OpenUserJS#643
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Oct 21, 2015
Martii added a commit that referenced this pull request Oct 21, 2015
Finish enabling hidden QSP in User Script List pages

Auto-merge
@Martii Martii merged commit 66d5fcd into OpenUserJS:master Oct 21, 2015
@Martii Martii deleted the makeUserScriptListsLibraryTriState branch October 21, 2015 11:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant