Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post fix typo #903

Merged
merged 1 commit into from
Feb 23, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/remove.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ function remove(aModel, aContent, aUser, aReason, aAutomated, aCallback) {
aContent.remove(function (aErr) {
if (aErr) {
console.error('Failed to remove', aModel.modelName);
aCallback(aErr);
aCallback(aErr); // NOTE: Same as `true` but specific e.g. stop all removal(s)
return;
}

if (aModel.modelName === 'User') {
aCallback(true); // NOTE: Stop any series removals
aCallback(true); // NOTE: Stop any series removals and done
} else {
aCallback(null); // NOTE: Continue any series and non-User single removals
}
Expand All @@ -128,7 +128,7 @@ exports.remove = function (aModel, aContent, aUser, aReason, aCallback) {
if (aModel.modelName !== 'User') {
remove(aModel, aContent, aUser, aReason, false, function (aErr) {
if (aErr) {
console.warn('Failed to remove User\n', aErr);
console.warn('Failed to remove', aModel.modelName, '\n', aErr);
aCallback(false);
return;
}
Expand Down