Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/intent_plugs #100

Closed
wants to merge 5 commits into from
Closed

Conversation

NeonJarbas
Copy link

@NeonJarbas NeonJarbas commented Mar 31, 2022

companion pr OpenVoiceOS/ovos-plugin-manager#47

key points:

  • load any number of intent plugins at once
  • an utterance may match more than 1 intent (multiple commands in a single utterance)
    • intents are executed sequentially, not at same time
  • intent types are intent, keyword_intent, regex_intent
  • unified bus api from core, skills dont care what plugins are available
  • weights to modify intent confidence per plugin can be set in mycroft.conf
  • split intent matching in stages for High/Medium/Low confidence ranges

@JarbasAl JarbasAl added the enhancement New feature or request label Mar 31, 2022
@JarbasAl JarbasAl requested a review from NeonDaniel March 31, 2022 06:12
Copy link
Member

@NeonDaniel NeonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial feedback from reading changes

@JarbasAl JarbasAl added the on hold blocked until next major release label Apr 20, 2022
@JarbasAl JarbasAl removed the on hold blocked until next major release label Jun 17, 2022
@JarbasAl JarbasAl mentioned this pull request Jun 20, 2022
NeonJarbas pushed a commit to NeonJarbas/ovos-core that referenced this pull request Aug 6, 2022
because fann2 is copyleft it was made optional in ovos-core, padaos was used instead of padatious

however padaos is very rigid and made intents virtually unusable, this replaces it with padacioso which is already a dependency dragged by OCP. It should be a little more usable and a drop in replacement

this is a temporary measure until OpenVoiceOS#100 is merged in version 0.0.5
@NeonJarbas NeonJarbas mentioned this pull request Aug 6, 2022
JarbasAl pushed a commit that referenced this pull request Aug 6, 2022
* feat/padacioso

because fann2 is copyleft it was made optional in ovos-core, padaos was used instead of padatious

however padaos is very rigid and made intents virtually unusable, this replaces it with padacioso which is already a dependency dragged by OCP. It should be a little more usable and a drop in replacement

this is a temporary measure until #100 is merged in version 0.0.5

* add couple test for intent register bus messages

* padacioso~=0.1.2

allow more than exact matches via the new fuzz flag

authored-by: jarbasai <[email protected]>
@JarbasAl JarbasAl added this to the 0.0.7 milestone Jan 26, 2023
@JarbasAl JarbasAl mentioned this pull request Feb 28, 2023
@JarbasAl JarbasAl force-pushed the feat/intent_plugs branch from 172f119 to d7d8a8f Compare April 22, 2023 08:25
@JarbasAl JarbasAl mentioned this pull request Apr 22, 2023
@JarbasAl JarbasAl mentioned this pull request Apr 28, 2023
36 tasks
@JarbasAl
Copy link
Member

replaced by #349 for now

@JarbasAl JarbasAl closed this Sep 27, 2023
@NeonJarbas NeonJarbas deleted the feat/intent_plugs branch January 6, 2024 01:38
@JarbasAl JarbasAl modified the milestones: 0.0.7, 0.0.8 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants