forked from MycroftAI/mycroft-core
-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/intent_plugs #100
Closed
Closed
feat/intent_plugs #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7182741
to
76d334a
Compare
NeonDaniel
reviewed
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial feedback from reading changes
Merged
NeonJarbas
pushed a commit
to NeonJarbas/ovos-core
that referenced
this pull request
Aug 6, 2022
because fann2 is copyleft it was made optional in ovos-core, padaos was used instead of padatious however padaos is very rigid and made intents virtually unusable, this replaces it with padacioso which is already a dependency dragged by OCP. It should be a little more usable and a drop in replacement this is a temporary measure until OpenVoiceOS#100 is merged in version 0.0.5
Merged
JarbasAl
pushed a commit
that referenced
this pull request
Aug 6, 2022
* feat/padacioso because fann2 is copyleft it was made optional in ovos-core, padaos was used instead of padatious however padaos is very rigid and made intents virtually unusable, this replaces it with padacioso which is already a dependency dragged by OCP. It should be a little more usable and a drop in replacement this is a temporary measure until #100 is merged in version 0.0.5 * add couple test for intent register bus messages * padacioso~=0.1.2 allow more than exact matches via the new fuzz flag authored-by: jarbasai <[email protected]>
172f119
to
d7d8a8f
Compare
Closed
replaced by #349 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion pr OpenVoiceOS/ovos-plugin-manager#47
key points: