Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle the "?" properly #16

Closed
goldyfruit opened this issue Dec 27, 2023 · 1 comment · Fixed by OpenVoiceOS/ovos-tts-server#19
Closed

Doesn't handle the "?" properly #16

goldyfruit opened this issue Dec 27, 2023 · 1 comment · Fixed by OpenVoiceOS/ovos-tts-server#19

Comments

@goldyfruit
Copy link
Member

When using the HTTP server provided by Piper, I don't have any trouble with the punctuation but when using this plugin, the "?" generates some trouble as I don't get any thing after it.

It seems to be related to "?" which should be escaped.

Sentence:

Why doesn't the Chimney-Sweep call out sick from work? Because he's used to working with a flue.

Result:

https://tts.smartgic.io/piper/synthesize/Why%20doesn't%20the%20Chimney-Sweep%20call%20out%20sick%20from%20work?%20Because%20he%27s%20used%20to%20working%20with%20a%20flue.?lang=en-us&voice=ryan-high

@goldyfruit
Copy link
Member Author

Just re-validated the issue again with this sentence (from the skill jokes).

Dec 30 18:06:56 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:56.599 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: skill-ovos-icanhazdadjokes.openvoiceos:joke.intent
Dec 30 18:06:56 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:56.651 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: mycroft.skill.handler.start
Dec 30 18:06:57 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:57.108 - HiveMind-voice-sat - hivemind_bus_client.protocol:handle_bus:201 - INFO - BUS: enclosure.active_skill
Dec 30 18:06:57 rpi4b hivemind-voice-sat[17132]: 2023-12-30 18:06:57.149 - HiveMind-voice-sat - ovos_audio.service:execute_tts:348 - INFO - Speak: What's Forest Gump's Facebook password? 1forest1

TTS didn't play "1forest1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant