Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update imports for py 3.10 compat #202

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl added the bug Something isn't working label Dec 17, 2023
@JarbasAl JarbasAl requested a review from j1nx December 17, 2023 17:52
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (8ef8580) 26.03% compared to head (971522d) 29.96%.
Report is 72 commits behind head on dev.

Files Patch % Lines
ovos_utils/enclosure/api.py 4.47% 64 Missing ⚠️
ovos_utils/sound/__init__.py 29.54% 31 Missing ⚠️
ovos_utils/messagebus.py 52.50% 19 Missing ⚠️
ovos_utils/gui.py 78.12% 14 Missing ⚠️
ovos_utils/intents/intent_service_interface.py 82.08% 12 Missing ⚠️
ovos_utils/events.py 77.77% 8 Missing ⚠️
ovos_utils/log.py 0.00% 7 Missing ⚠️
ovos_utils/skills/api.py 60.00% 6 Missing ⚠️
ovos_utils/__init__.py 78.26% 5 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/__init__.py 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #202      +/-   ##
==========================================
+ Coverage   26.03%   29.96%   +3.93%     
==========================================
  Files          49       49              
  Lines        6376     6557     +181     
==========================================
+ Hits         1660     1965     +305     
+ Misses       4716     4592     -124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@j1nx j1nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure how to test this properly within the containarized system but as it is such a small change I would say; merge and push.

@JarbasAl JarbasAl merged commit f844113 into dev Dec 18, 2023
6 of 10 checks passed
@JarbasAl JarbasAl deleted the update-imports-for-py-3.10-compat branch December 18, 2023 18:19
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module 'collections' has no attribute 'MutableSequence'
2 participants