Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

support hex parameters in Account.send #253

Merged
merged 3 commits into from
Oct 31, 2022
Merged

support hex parameters in Account.send #253

merged 3 commits into from
Oct 31, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Oct 24, 2022 •
edited
Loading

Fixes #254

@martriay martriay changed the title Fix account's send support hex parameters in Account.send Oct 25, 2022
andrew-fleming
andrew-fleming approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@martriay martriay requested a review from ericnordelo October 31, 2022 15:51
ericnordelo
ericnordelo approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martriay martriay merged commit f9d1edc into main Oct 31, 2022
@martriay martriay deleted the fix-send branch October 31, 2022 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrew-fleming andrew-fleming andrew-fleming approved these changes

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account.send does not accept hex values as parameters
3 participants
@martriay @ericnordelo @andrew-fleming