The Secondary's primary is now private.

OpenZeppelin · Aug 30, 2018 · 5ca4023 · 5ca4023
1 parent 622df07
commit 5ca4023
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/contracts/ownership/Secondary.sol b/contracts/ownership/Secondary.sol
@@ -6,7 +6,7 @@ pragma solidity ^0.4.24;
  * @dev A Secondary contract can only be used by its primary account (the one that created it)
  */
 contract Secondary {
-  address public primary;
+  address private primary;
 
   /**
    * @dev Sets the primary account to the one that is creating the Secondary contract.

diff --git a/test/ownership/Secondary.test.js b/test/ownership/Secondary.test.js
@@ -12,10 +12,6 @@ contract('Secondary', function ([_, primary, newPrimary, anyone]) {
     this.secondary = await SecondaryMock.new({ from: primary });
   });
 
-  it('stores the primary\'s address', async function () {
-    (await this.secondary.primary()).should.equal(primary);
-  });
-
   describe('onlyPrimary', function () {
     it('allows the primary account to call onlyPrimary functions', async function () {
       await this.secondary.onlyPrimaryMock({ from: primary });
@@ -27,11 +23,6 @@ contract('Secondary', function ([_, primary, newPrimary, anyone]) {
   });
 
   describe('transferPrimary', function () {
-    it('makes the recipient the new primary', async function () {
-      await this.secondary.transferPrimary(newPrimary, { from: primary });
-      (await this.secondary.primary()).should.equal(newPrimary);
-    });
-
     it('reverts when transfering to the null address', async function () {
       await assertRevert(this.secondary.transferPrimary(ZERO_ADDRESS, { from: primary }));
     });
@@ -40,7 +31,7 @@ contract('Secondary', function ([_, primary, newPrimary, anyone]) {
       await assertRevert(this.secondary.transferPrimary(newPrimary, { from: anyone }));
     });
 
-    context('with new primary', function () {
+    context('after transferring to new primary account', function () {
       beforeEach(async function () {
         await this.secondary.transferPrimary(newPrimary, { from: primary });
       });