assertRevert: Fix late return bug #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now ensure that if an exception is thrown while awaiting the promise, the exception _has_ to be a revert. We throw 'Expected revert not received' only afterwards. This solves any problems with confusing the word 'revert'. Fix OpenZeppelin#775
nventuro
approved these changes
Jul 27, 2018
|
Great @justuswilhelm, thanks! I can't wait to get to #1078 so that we can properly test this stuff and prevent it in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
🚀 Description
We now ensure that if an exception is thrown while awaiting the promise,
the exception has to be a revert. We throw 'Expected revert not
received' only afterwards. This solves any problems with confusing the
word 'revert'.
npm run lint:all:fix).