-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve encapsulation on lifecycle, ownership and payments #1269
Merged
frangio
merged 17 commits into
OpenZeppelin:master
from
come-maiz:refactor/1174/private-state-vars
Sep 5, 2018
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
97be1da
Improve encapsulation on Pausable
come-maiz 3a2c242
add the underscore
come-maiz 6416991
Improve encapsulation on ownership
come-maiz 82f23f0
fix rebase
come-maiz 2842284
fix ownership
come-maiz fe431bf
Improve encapsulation on payments
come-maiz bb5a1a9
Add missing tests
come-maiz 63ee53f
add missing test
come-maiz 1e69a33
Merge branch 'master' into refactor/1174/private-state-vars
come-maiz bd25984
Do not prefix getters
come-maiz 647b4b2
Merge branch 'master' into refactor/1174/private-state-vars
come-maiz b3b4195
Fix tests.
come-maiz fc473b4
revert pending owner reset
come-maiz 5d04b0a
add missing underscore
come-maiz 61a7f21
Merge branch 'master' into refactor/1174/private-state-vars
come-maiz 68ebdb0
Merge branch 'master' into refactor/1174/private-state-vars
come-maiz 436ceeb
Add missing underscore
come-maiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing underscore suffix! π£
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goddammit! I should have breakfast first :D