Made some TokenVesting public functions private. #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
added
contracts
come-maiz
approved these changes
Oct 17, 2018
|
I agree with your concern, but this fixed version works properly, and is a draft anyway. We'll probably do a full redesign of the vesting contract, since some schemes are not supported by it (see #1214). |
come-maiz
pushed a commit
that referenced
this pull request
Oct 21, 2018
* Made some TokenVesting public functions private. * Fixed linter error. (cherry picked from commit df3c113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VestedAmountcan be manipulated by transferring tokens, so while the contract works properly in all cases, it makes no sense to expose this intermediate value.