GSNSignatureBouncer fix #1920
Merged
GSNSignatureBouncer fix #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Great work @crazyrabbitLTC, this is a great catch! I had not realized the implications behind allowing this.
Let's do a review here and then migrate those changes to the ethereum-package repo.
Makes sense! Co-Authored-By: Nicolás Venturo <[email protected]>
ok! Co-Authored-By: Nicolás Venturo <[email protected]>
…zeppelin-contracts into GSNSignatureBouncerFix
|
@crazyrabbitLTC I reverted some reformatting that I assume was automatically done by Prettier. Please be careful not to include that sort of thing in the PR, at least unless intended. 🙂 |
frangio
approved these changes
Oct 1, 2019
frangio
pushed a commit
that referenced
this pull request
Oct 29, 2019
* GSNSignatureBoucer does not accept zero address * Linting code. * Update contracts/GSN/bouncers/GSNBouncerSignature.sol Makes sense! Co-Authored-By: Nicolás Venturo <[email protected]> * Update test/GSN/GSNBouncerSignature.test.js ok! Co-Authored-By: Nicolás Venturo <[email protected]> * Add zero address constant from OZ test Helpers * revert prettier formatting (cherry picked from commit f9a9478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OpenZeppelin/openzeppelin-contracts-upgradeable#67
Current version of the code means the GSNSignatureBouncer will accept Zero Addresses as a trusted signer. The result is that unexpectedly the contract will accept the absence of a signature as a valid signature. The added check prevents the constructor from being called with a zero address.
Fixes #
A require statement was added on the constructor to prevent Zero Address from being supplied as the Trusted Signer. This will prevent the contract being deployed with a Zero Address.
I added a test to check this functionality.