Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSN renaming #1963

Merged
merged 8 commits into from
Oct 25, 2019
Merged

GSN renaming #1963

merged 8 commits into from
Oct 25, 2019

Conversation

nventuro
Copy link
Contributor

This PR:

  • removes the 'bouncer' concept
  • renames Bouncer contracts to Recipients (e.g. GSNRecipientSignature)

@nventuro nventuro requested a review from frangio October 24, 2019 19:48
@nventuro nventuro mentioned this pull request Oct 24, 2019
Merged
frangio
frangio reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

contracts/GSN/GSNRecipient.sol Outdated Show resolved Hide resolved
contracts/GSN/GSNRecipient.sol Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/gsn-strategies.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/gsn-strategies.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/gsn-strategies.adoc Outdated Show resolved Hide resolved
@nventuro nventuro merged commit aae95db into OpenZeppelin:master Oct 25, 2019
@nventuro nventuro deleted the gsn-rename branch October 25, 2019 16:37
frangio pushed a commit that referenced this pull request Oct 29, 2019
@nventuro @frangio
GSN renaming (#1963)
6efbee6 
* Merge GSNBouncerBase into GSNRecipient

* Remove emtpy implementations for _pre and _post

* Rename bouncers to recipients

* Rename bouncers documentation to strategies

* Rewrite guides and docstrings to use the strategy naming scheme

* Address review comments

* Apply suggestions from code review

Co-Authored-By: Francisco Giordano <[email protected]>

* change wording of docs

(cherry picked from commit aae95db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio