Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SafeERC20.sol #2246

Merged
merged 1 commit into from
May 26, 2020
Merged

Update SafeERC20.sol #2246

merged 1 commit into from
May 26, 2020

Conversation

Ro5s
Copy link
Contributor

@Ro5s Ro5s commented May 25, 2020

tweak intro dev comment to reflect more typical use case, wrapping an IERC20 reference for a deposit contract using others' ERC-20 tokens.

I might be mistaken ~ but typically SafeERC20 won't be used in conjunction with ERC20 for OZ token deployments?

@Ro5s
Update SafeERC20.sol
c987e10 
tweak intro dev comment to reflect more typical use case, wrapping an `IERC20` reference for a deposit contract using others' ERC-20 tokens. I might be mistaken ~ but typically SafeERC20 won't be used in conjunction with ERC20 for OZ token deployments?
frangio
frangio approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct! It's definitely possible that someone would use an ERC20 address type as a function argument when they meant IERC20 though, but that would be a mistake.

@frangio frangio merged commit 424ab2a into OpenZeppelin:master May 26, 2020
@frangio
Copy link
Contributor

frangio commented May 26, 2020

Thank you!

frangio pushed a commit that referenced this pull request May 26, 2020
@Ro5s @frangio
Update SafeERC20.sol (#2246)
324a977 
tweak intro dev comment to reflect more typical use case, wrapping an `IERC20` reference for a deposit contract using others' ERC-20 tokens. I might be mistaken ~ but typically SafeERC20 won't be used in conjunction with ERC20 for OZ token deployments?

(cherry picked from commit 424ab2a)
frangio pushed a commit that referenced this pull request May 26, 2020
@Ro5s @frangio
Update SafeERC20.sol (#2246)
f24b16a 
tweak intro dev comment to reflect more typical use case, wrapping an `IERC20` reference for a deposit contract using others' ERC-20 tokens. I might be mistaken ~ but typically SafeERC20 won't be used in conjunction with ERC20 for OZ token deployments?

(cherry picked from commit 424ab2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ro5s @frangio