Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Remove presets #3470

Closed
wants to merge 5 commits into from
Closed

[next] Remove presets #3470

wants to merge 5 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 13, 2022

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx marked this pull request as draft June 13, 2022 21:21
@Amxx Amxx closed this Jun 13, 2022
@Amxx Amxx reopened this Jun 13, 2022
@Amxx Amxx changed the base branch from master to next June 13, 2022 21:25
@Amxx Amxx changed the title [5.0.0] Remove presets [next] Remove presets Jun 13, 2022
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (upgraded) postinstall package.json via [email protected], @ethereumjs/[email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules

Powered by socket.dev

@Amxx
Copy link
Collaborator Author

Amxx commented Aug 19, 2022

Tests fail because of the contract migration script.

The migration script rewrite imports between version. From version 3 to version 4, the presets path are rewritten. If we remove the presets, we need to consider how to deal with that. Error ? No rewrite ?

@Amxx Amxx deleted the branch OpenZeppelin:next August 19, 2022 14:31
@Amxx Amxx closed this Aug 19, 2022
@Amxx Amxx mentioned this pull request Aug 19, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant