Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Context & ERC2771 tests to ethers.js #4737

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Migrate Context & ERC2771 tests to ethers.js #4737

merged 7 commits into from
Nov 23, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Nov 13, 2023

Duplicate of #4732. Need resolution/merging

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1fc59b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw mentioned this pull request Nov 17, 2023
Closed
@ernestognw ernestognw added the tests Test suite and helpers. label Nov 17, 2023
@ernestognw ernestognw mentioned this pull request Nov 23, 2023
Closed
3 tasks
ernestognw
ernestognw approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging requires 1 approval, so I'm approving this one and merging instead of #4732

@ernestognw ernestognw merged commit e473bcf into OpenZeppelin:master Nov 23, 2023
@Amxx Amxx deleted the test/migration/context branch November 23, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @ernestognw