Fix shouldFail.reverting.withMessage on non-Ganache #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `shouldFail.reverting.withMessage` tries to execute the following regular expression match: ``` /TestRPC\/v([0-9.]+)\/ethereum-js/.exec(web3ClientVersion) ``` When `web3ClientVersion` has a value like `Geth/v1.8.9-unstable-d4ac250e/linux-amd64/go1.9.4`, which would likely occur when testing against any non-Ganache chain implementation, `RegExp.prototype.exec()` would return `null` causing an error like: ``` TypeError: Cannot use 'in' operator to search for '1' in null ``` when `1 in matches` is evaluated in the subsequent code. This patch fixes things by testing for `matches` being `null` or `matches[1]` not being valid explicitly. Tested with `npm run test` and `npm run test-integration`.
scottt
force-pushed
the
fix-shouldFail.reverting.withMessage-on-non-ganache
branch
from
9737be0 to
a58fd87
Compare
Like this? :) |
nventuro
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
shouldFail.reverting.withMessagetries to execute the followingregular expression match:
When
web3ClientVersionhas a value likeGeth/v1.8.9-unstable-d4ac250e/linux-amd64/go1.9.4,which would likely occur when testing against any non-Ganache
chain implementation,
RegExp.prototype.exec()would returnnullcausing an error like:
when
1 in matchesis evaluated in the subsequent code.This patch fixes things by testing for
matchesbeingnullormatches[1]not being valid explicitly.Tested with
npm run testandnpm run test-integration.