Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contract size and add custom override #86

Merged
merged 27 commits into from
Mar 8, 2022
Merged

Fix contract size and add custom override #86

merged 27 commits into from
Mar 8, 2022

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Mar 3, 2022 •
edited
Loading

  • Fix the way getContractSize handles slots
    • check extensively
  • Handle the fact that some immutable slots are made private by the transpiler, and must be counted toward the contract size
  • support custom contract size

@Amxx Amxx force-pushed the fixContractSize branch from da5575e to 46ff849 Compare March 3, 2022 15:31
frangio
frangio reviewed Mar 3, 2022
View reviewed changes
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
@Amxx Amxx marked this pull request as ready for review March 7, 2022 17:28
frangio
frangio reviewed Mar 8, 2022
View reviewed changes
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
contracts/TransformCustomSize.sol Outdated Show resolved Hide resolved
contracts/TransformCustomSize.sol Outdated Show resolved Hide resolved
contracts/TransformCustomSize.sol Outdated Show resolved Hide resolved
frangio
frangio requested changes Mar 8, 2022
View reviewed changes
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
src/transformations/add-storage-gaps.ts Outdated Show resolved Hide resolved
@frangio frangio mentioned this pull request Mar 8, 2022
Merged
3 tasks
frangio
frangio approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!

@frangio frangio merged commit d3b8389 into master Mar 8, 2022
@frangio frangio deleted the fixContractSize branch March 8, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio