New Hashmap functionality added #42
Conversation
|
Hey there! 👋 This repository uses the Prettier code style. You forgot to format these files in your pull request:
The Prettier installation guide is a good place to get started with formatting your code properly. ❤️ Your friendly Prettifier bot. |
| index = randomInt(0, array.length); | ||
| } | ||
| viewed[index] = 1; | ||
| return array[index].line; |
There was a problem hiding this comment.
So, here it will check if the line is previously generated or not, and if it is not generated then it will return the line?
It will be great if you can provide a short description of what your code exactly does
There was a problem hiding this comment.
Yeah ohk i will just desribe those
|
hey @AnirudhPanda I have added those descriptions you asked for hope this time my PR gets merged , thank you |
|
Hey, @gitaalekhyapaul would you mind testing this? I guess this is done only for the |
|
@AnirudhPanda you can go ahead and merge the new functionalities if you like, I'll add tests for them in #36 |
|
|
I guess for that we need to then add hashmap for every type of quote like for inspire and cheerful etc ... |
Currently we have the |
* Update data.json * Update data.json Co-authored-by: Anirudh Panda <[email protected]>
github-actions
bot
added
data
|
Hey @AnirudhPanda I made those changes you requested in readme file but unable to push on v1.2.0 |
Hey @AnirudhPanda I have created new Hashmap issue and also PR please have a look .