Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): add labware repository JSON interface #15390

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Jun 11, 2024

Overview

This PR creates a JSON schema for the labware repository interface outlined here: https://opentrons.atlassian.net/wiki/spaces/RPDO/pages/4081647645/Decoupling+Labware+from+Robots#Labware-Repositories

This idea is that this interface will be recognized by the software system as a first class citizen (much like protocols and labware definitions). The next steps:

  • The app should recognize and store a protocol's labware repository along side its in app protocol storage
  • The robot server should accept a protocol's labware repository and store it along side robot protocol storage

Changelog

  • Add labware repository JSON interface

Risk assessment

Low

@shlokamin shlokamin requested a review from sfoster1 June 12, 2024 13:52
@shlokamin shlokamin marked this pull request as ready for review June 12, 2024 13:52
@shlokamin shlokamin requested a review from a team as a code owner June 12, 2024 13:52
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very into it!

Copy link
Contributor

A PR has been opened to address analyses snapshot changes. Please review the changes here: #15497

@sfoster1 sfoster1 changed the title feat(shared-data): add labware respsitory JSON interface feat(shared-data): add labware repository JSON interface Sep 3, 2024
@shlokamin shlokamin merged commit bb0db4a into edge Sep 3, 2024
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants