feat(app, app-shell, app-shell-odd): remove analytics modals and migrate analytics to default to on #15505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
changed the title
shlokamin
changed the title
koji
reviewed
Jun 25, 2024
| expect(result).toEqual(MOCK_CONFIG_V22) | ||
| }) | ||
| it('should keep version 22', () => { | ||
| const v21Config = MOCK_CONFIG_V22 |
There was a problem hiding this comment.
Suggested change
| const v21Config = MOCK_CONFIG_V22 | |
| const v22Config = MOCK_CONFIG_V22 |
koji
reviewed
Jun 25, 2024
| }) | ||
| it('should keep version 22', () => { | ||
| const v21Config = MOCK_CONFIG_V22 | ||
| const result = migrate(v21Config) |
There was a problem hiding this comment.
Suggested change
| const result = migrate(v21Config) | |
| const result = migrate(v22Config) |
There was a problem hiding this comment.
oops i forgot to push these changes before i merged... i will do this in another PR
koji
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR migrates the desktop app and ODD's analytics config to default to on. It also removes the
seenOptInconfig value since it is no longer used. Finally, it removes the app analytics modals that show up when you open the desktop app/ODD for the first time.closes AUTH-529, AUTH-530, AUTH-532, AUTH-533
Test Plan
This one is sort of hard to test — make sure the code looks good and that the migration does what you'd expect. We'll just have to make sure to battle test this one in QA cc @nusrat813 and @y3rsh
Changelog
Review requests
See test plan
Risk assessment
Medium