feat(app): hide unused env vars from vite dist #16720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Nov 7, 2024
shlokamin
added a commit
that referenced
this pull request
Nov 7, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Oopsy, we were passing in a bunch of env variables into our app builds that the app did not need. This PR only passes in the node env and the mixpanel id for the frontend to use.
Test Plan and Hands on Testing
Build the app which some rogue env variables and look at the dist, you should only see a mixpanel id and node env, nothing else.
Changelog
Review requests
See test plan
Risk assessment
Low/med