Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot gitsubmodule check for end of week #219

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Dec 18, 2023

Issues

Changelog

Add gitsubmodule check to dependabot config as an extra reminder to update submodules at the end of the week. This can help ensure the cli stays up to date with the latest opslevel-go code

Setting branch = main in .gitmodules lets task setup use git submodule update --remote to always get the latest commit from main

  • List your changes here
  • Make a changie entry, N/A

Tophatting

@davidbloss davidbloss requested review from rocktavious and a user December 18, 2023 16:43
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (587f497) 6.29% compared to head (ac1586b) 6.29%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #219   +/-   ##
=====================================
  Coverage   6.29%   6.29%           
=====================================
  Files          5       5           
  Lines        254     254           
=====================================
  Hits          16      16           
  Misses       238     238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to not make this daily? 🤔

@davidbloss
Copy link
Contributor Author

Is there any reason to not make this daily? 🤔

My take is this should be an extra safety net around the time we release the code. But a primary (automatic) solution is what we need, and I updated task setup to automatically pull the latest from opslevel-go's main branch.

@davidbloss davidbloss merged commit fd17e83 into main Dec 18, 2023
@davidbloss davidbloss deleted the db/add-gitsubmodule-to-dependabot branch December 18, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant