Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql cmd correctly handles errors with field args #323

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

davidbloss
Copy link
Contributor

Issues

Error: error parsing variable 'owner=platform' | %!w()

Changelog

  • List your changes here
  • Make a changie entry

Tophatting

@davidbloss davidbloss requested a review from rocktavious August 19, 2024 21:42
@davidbloss davidbloss self-assigned this Aug 19, 2024
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Not really sure what this handleErr function Taimoor built is but it seems duplicative of cobra.CheckErr.

I loged a ticket to come back around and clean this up. https://github.com/OpsLevel/team-platform/issues/440

@davidbloss davidbloss merged commit 6f29745 into main Aug 20, 2024
4 checks passed
@davidbloss davidbloss deleted the db/correctly-handle-graphql-parsing branch August 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants