Followup - prevent handleRepositories from crashing | Stop using pointers in logs | Fix fetching service from repo

[taimoorgit]

Issues

https://github.com/OpsLevel/team-platform/issues/243

#260

Changelog

• Prevent call to repo.GetService() that crashes if the base directory is nil.
• Use JSON marshal for logging so that logs aren't full of pointers (that happens when using %+v)
• Make a changie entry

Tophatting

I am using the sample config on our dev cluster.

On a deployment, I added an annotation that attached a repository.

6:39PM INF [redis] Attached repository '{"service":null,"repository":{"alias":"github.com:jason-opslevel/a_repo"},"baseDirectory":"/","displayName":"My Cool Repo"}'
6:42PM ERR [JSONRPC APIz] Failed assigning repository '{"service":null,"repository":{"alias":"github.com:jason-opslevel/a_repo"},"baseDirectory":"/","displayName":"My Cool Repo"}'
	REASON: OpsLevel API Errors:
	- 'repository' Repository is already linked to this service at this path.

I noticed I could never encounter the path where the repository gets renamed because the code isn't smart enough to know the baseDirectory "/" == "". Had to make this opslevel-go change for that to work: OpsLevel/opslevel-go#374

Result is that repository names actually get updated.

7:06PM INF [JSONRPC APIz] Updated repository '{"service":null,"repository":{"alias":"github.com:jason-opslevel/a_repo"},"baseDirectory":"/","displayName":"Hello Redis"}'

Later run:

7:25PM DBG [JSONRPC APIz] Repository '{"service":null,"repository":{"alias":"github.com:jason-opslevel/a_repo"},"baseDirectory":"/","displayName":"Hello Redis"}' already attached to service ... skipping

An invalid repo doesn't crash the program:

7:30PM ERR [web] Failed assigning repository '{"service":null,"repository":{"alias":"---------------invalidrepo------------------"},"baseDirectory":"/","displayName":"Hello Redis"}'
	REASON: OpsLevel API Errors:
	- 'alias' '---------------invalidrepo------------------' does not identify a repository on this account

[taimoorgit]

#36

Checking for string "null" because of this^